Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update annotated.jl docstrings according to #55741 #56736

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Update annotated.jl docstrings according to #55741 #56736

merged 5 commits into from
Dec 3, 2024

Conversation

danielwe
Copy link
Contributor

@danielwe danielwe commented Dec 2, 2024

@LilithHafner
Copy link
Member

Good catch, thanks! Would you also change those julia-repl blocks to jldoctest so that in the future these types of mistakes will make CI fail?

@LilithHafner LilithHafner added docs This change adds or pertains to documentation strings "Strings!" labels Dec 2, 2024
@danielwe
Copy link
Contributor Author

danielwe commented Dec 2, 2024

Done!

@tecosaur
Copy link
Contributor

tecosaur commented Dec 3, 2024 •
edited
Loading

Looks good to me! I do wonder if it would be better to have using Base.AnnotatedString as the doctest setup, even though it is technically private, just for the sake of not loading a stdlib for a Base doctest.

@LilithHafner
Copy link
Member

Great! Thanks for the update.

@LilithHafner LilithHafner merged commit 2590e67 into JuliaLang:master Dec 3, 2024
4 of 7 checks passed
@danielwe danielwe deleted the patch-3 branch December 3, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielwe @LilithHafner @tecosaur